Changeset 4484 for trunk/lib/Doctrine

Timestamp:

06/08/08 17:42:55 (7 months ago)

Author:

guilhermeblanco

Message:

Cosmetics changes in EventManager?, renamed the registerEventListener to addEventListener, optimized the source and changed the arguments order. Commented an echo line in RangeVariableDeclaration?

Location:

trunk/lib/Doctrine

Files:

• EventManager.php (modified) (2 diffs)
• Query/Production/RangeVariableDeclaration.php (modified) (1 diff)

trunk/lib/Doctrine/EventManager.php

@@ -7 +7 @@
     private $_listeners = array();
 
+
     public function dispatchEvent($event) {
         $argIsCallback = is_string($event);
         $callback = $argIsCallback ? $event : $event->getType();
-        
+
         if (isset($this->_listeners[$callback])) {
             $event = $argIsCallback ? new Doctrine_Event($event) : $event;
@@ -20 +21 @@
         return ! $event->getDefaultPrevented();
     }
-    
+
+
     public function getListeners($callback = null) {
         return $callback ? $this->_listeners[$callback] : $this->_listeners;
     }
-    
+
+
     public function hasListeners($callback) {
         return isset($this->_listeners[$callback]);
     }
-    
-    public function registerEventListener($listener, $callbacks) {
+
+
+    public function addEventListener($callbacks, $listener) {
         // TODO: maybe check for duplicate registrations?
-        if (is_array($callbacks)) {
-            foreach ($callbacks as $callback) {
-                $this->_listeners[$callback] = $listener;
-            }
-        } else {
-            $this->_listeners[$callbacks] = $listener;
+        if ( ! is_array($callbacks)) {
+            $callbacks = array($callbacks);
+        }
+
+        foreach ($callbacks as $callback) {
+            $this->_listeners[$callback] = $listener;
         }
     }

trunk/lib/Doctrine/Query/Production/RangeVariableDeclaration.php

@@ -217 +217 @@
                     $parent = $path;
                 } catch (Doctrine_Exception $e) {
-                    echo "Tried to load class metadata from '".$relationName."'\n";
+                    //echo "Tried to load class metadata from '".$relationName."'\n";
                     $this->_parser->semanticalError($e->getMessage());